ru.linux

 
 - RU.LINUX ---------------------------------------------------------------------
 From : Oleg Drokin                          2:5020/400     29 Apr 2003  15:04:21
 To : Andrey Ovchinnikov
 Subject : Re: Help! Busy inodes after unmount!
 -------------------------------------------------------------------------------- 
 

 Hello!
 
 Andrey Ovchinnikov <Andrey.Ovchinnikov@p49.f70.n467.z2.fidonet.org> wrote:
 
 AO> Очень часто при shutdown'е системы вылазит следующее сообщение:
 AO> "Unmounting file system...VFS:Busy inodes after unmount. Self destruct
 AO> in 5 seconds. Have a nice day!"
 
 Какого рода активность характерна для этой файловой системы?
 
 AO> Как определить почему не освобождаются некоторые inodes? Файловая
 AO> система - ReiserFS 3.6.25, ядро 2.4.20, mount/unmount - 2.11z. 
 AO> Hа ФС ошибок нет - проверял многократно.
 
 Гм, а вот такой вот патч случайно не помогает?
 
 ===== fs/reiserfs/inode.c 1.42 vs edited =====
 - --- 1.42/fs/reiserfs/inode.c Thu Feb 13 15:42:42 2003
 +++ edited/fs/reiserfs/inode.c Thu Feb 20 17:23:24 2003
 @@ -20,6 +20,10 @@
  static int reiserfs_get_block (struct inode * inode, long block,
               struct buffer_head * bh_result, int create);
  
 +/* This spinlock guards inode pkey in private part of inode
 +   against race between find_actor() vs reiserfs_read_inode2 */
 +static spinlock_t keycopy_lock = SPIN_LOCK_UNLOCKED;
 +
  void reiserfs_delete_inode (struct inode * inode)
  {
      int jbegin_count = JOURNAL_PER_BALANCE_CNT * 2; 
 @@ -898,8 +902,9 @@
      bh = PATH_PLAST_BUFFER (path);
      ih = PATH_PITEM_HEAD (path);
  
 -
 +    spin_lock(&keycopy_lock);
      copy_key (INODE_PKEY (inode), &(ih->ih_key));
 +    spin_unlock(&keycopy_lock);
      inode->i_blksize = PAGE_SIZE;
  
      INIT_LIST_HEAD(&inode->u.reiserfs_i.i_prealloc_list) ;
 @@ -1220,10 +1225,27 @@
           unsigned long inode_no, void *opaque )
  {
      struct reiserfs_iget4_args *args;
 +    int retval;
  
      args = opaque;
 +    /* We protect against possible parallel init_inode() on another CPU here.
 */
 +    spin_lock(&keycopy_lock);
      /* args is already in CPU order */
 -    return le32_to_cpu(INODE_PKEY(inode)->k_dir_id) == args -> objectid;
 +    if (le32_to_cpu(INODE_PKEY(inode)->k_dir_id) == args -> objectid)
 +  retval = 1;
 +    else
 +  /* If The key does not match, lets see if we are racing
 +     with another iget4, that already progressed so far
 +     to reiserfs_read_inode2() and was preempted in
 +     call to search_by_key(). The signs of that are:
 +       Inode is locked
 +       dirid and object id are zero (not yet initialized)*/
 +  retval = (inode->i_state & I_LOCK) &&
 +      !INODE_PKEY(inode)->k_dir_id &&
 +      !INODE_PKEY(inode)->k_objectid;
 +
 +    spin_unlock(&keycopy_lock);
 +    return retval;
  }
  
  struct inode * reiserfs_iget (struct super_block * s, const struct cpu_key *
 key)
 
 Bye,
     Oleg
 --- ifmail v.2.15dev5
  * Origin: Green's home news server (2:5020/400)
 
 

Вернуться к списку тем, сортированных по: возрастание даты  уменьшение даты  тема  автор 

Тема:    Автор:    Дата:    Help! Busy inodes after unmount!   Andrey Ovchinnikov   29 Apr 2003 11:48:38   Re: Help! Busy inodes after unmount!   Oleg Drokin   29 Apr 2003 15:04:21